style: Fix math-constant (FURB152) #4049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ery_sigsetfile.py
…est_imagery_sigsetfile.py"
…magery_sigsetfile.py
ninsbl
approved these changes
Jul 14, 2024
|
@ninsbl Do you have a preference between these two for the next PR: Fixing the INT001, INT002, and INT003 (the translated string is formatted before getting passed to gettext), or fixing 2148 string formatting with printf. Some of the INT errors use percent formatting. |
|
I think I answered myself. To prevent useless fixes (and conflicts), I'll solve the gettext errors before, and they maybe won't have to convert to printf afterwards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff rule: https://docs.astral.sh/ruff/rules/math-constant/
The rule finds hard-coded constants like pi, tau, e, and replaces it with the constants from
math.Two files are affected. One seems unused (a test.py that isn't run as tests), and a test file in imagery. Since the complete test file seemed to use two decimal points, I reverted and added a per-file-ignore. I made it in a separate commit so it would be possible to see what it looks like with the change.